EWLayer && oneDNN#217
Conversation
| void build_graph(it_lab_ai::Tensor& input, it_lab_ai::Tensor& output, | ||
| const std::string& json_path, bool comments, bool parallel) { | ||
| const std::string& json_path, bool comments, bool parallel, | ||
| bool onednn) { |
There was a problem hiding this comment.
the parameter is passed through build_graph -> parse_json_model to create a layer with or without oneDNN. I'm still thinking about the best way to organize this
There was a problem hiding this comment.
The fact that the layer is being executed using oneDNN (or any other way) is purely dependent on how do we execute the ready-to-use graph. Actually "parallel" parameter is also not very good idea, and we will need to get rid of this (I have created a task out of it: #218, may be resolved later)
So, theoretically we should be able to take a graph out, serialize it anyhow, store it and be able to execute (without any re-configuration on the graph level) it in different ways: sequentially, in parallel, using SYCL/Kokkos/oneDNN, etc.
Semyon1104
force-pushed
the
Semyon1104/IntegrateOneDNN
branch
from
8cf3438 to
b57dba8
Compare
…ded-dev-research/itlab_2023 into Semyon1104/IntegrateOneDNN
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #217 +/- ##
==========================================
- Coverage 84.06% 83.84% -0.23%
==========================================
Files 42 44 +2
Lines 2667 2655 -12
Branches 1397 1466 +69
==========================================
- Hits 2242 2226 -16
+ Misses 220 219 -1
- Partials 205 210 +5 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
…ded-dev-research/itlab_2023 into Semyon1104/IntegrateOneDNN
…ded-dev-research/itlab_2023 into Semyon1104/IntegrateOneDNN
…ded-dev-research/itlab_2023 into Semyon1104/IntegrateOneDNN
| - name: Set binary path | ||
| id: set_eval_binary | ||
| run: | | ||
| echo "EVAL_BINARY=build/bin/ACC" >> $GITHUB_OUTPUT |
There was a problem hiding this comment.
Please, leave this as is. I think this output is redundant and the CI script becomes more fragile due to this. Similar comment is applicable for other modifications of CI scripts. Please, remove debug output here and all temporary workarounds
Semyon1104
force-pushed
the
Semyon1104/IntegrateOneDNN
branch
3 times, most recently
from
a002eaf to
c6ac48e
Compare
Semyon1104
force-pushed
the
Semyon1104/IntegrateOneDNN
branch
from
ed4739a to
c6ac48e
Compare
2 participants
#213